-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image: Hide caption control when multi-editing images #57357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
[Block] Image
Affects the Image Block
labels
Dec 23, 2023
Mamaduka
requested review from
artemiomorales and
michalczaplinski
as code owners
December 23, 2023 09:29
Size Change: +3 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Regarding this issue, I think it needs to be fixed in the Gallery block and the Video block as well, so I submitted #57369.
03773ce74064b60d060a9638cb06ee24.mp4
@t-hamano, good catch. I can follow-up on those blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #27105.
PR hides the "Add caption" option when multi-editing image blocks.
Why?
Clicking the button currently does nothing. Editing sources like
caption
andalt
can cause a loss of content when multiple image blocks are selected.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast